-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the userdoc directory #2283
Restructure the userdoc directory #2283
Conversation
|
Yes, I agree to some extent - I would not want devdoc under userdoc; this was just a way to get the docs to build with the current hierarchy.
Yes, I showed the toc page to highlight the structure. But this page is available on Read the docs (currently if you click the nest logo I think you get contents.html, automatically). It is what the sidebar will show on every page, including the new theme.
Probably not - I am up for removing it, and any alternative naming suggestions. |
Co-authored-by: Pooja Babu <[email protected]>
…l/nest-simulator into new-doc-folder-structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jessica-mitchell The CI is failing for something unrelated to the changes in this PR. Otherwise, this looks good to me.
Inspired by https://documentation-for-annarchy.readthedocs.io/, can we have a menu that only has the items:
By "subsume", I mean these pages go under this part of the hierarchy. All of these top-level menu items would be collapsed by default, giving some space rather than the overwhelming number of items there are now. |
I see they are using the material theme, which is what we'll be moving towards. I understand there are a lot of topics on the toc, but I am a little weary of hiding topics too.
I do agree though that many of these links can be subsumed. However, due to the lack of proper citations we have encountered I think "cite NEST" should be very visible. (How this should be handled exactly I am not sure)
I am not really in favour of the word "manual", my first thought when I read "manual" is some very dense, 5000 page instruction booklet. Directories like glossaries, in at least my head, fit very much into the reference material category.
I like tutorials as a separate category, or at least keeping the term visible.
What do you mean by C++ API?
So I went ahead and played with the toc to fit with what you describe, and so I can get a feel for it and found its behaviour not as nice as the example you provided.
So after all that - I think you have a valid point, and we could probably condense this list, but I am not convinced that it makes sense to do it to such a degree, as is for annarchy, nor do I really want to fight with the sphinx-rtd-theme, if I have a PR waiting in the wings with the a new theme that would need to be configured differently. My suggestion would be to have as headlines
I would also suggest doing this in new theme |
Thanks for your kind response to my radical suggestions!
Just focusing on the menu for now.
Absolutely sympathize in having descriptive titles rather than words that are thinly veiled synonyms of "miscellaneous". "How NEST works" also good.
"Tutorials" instead of "Examples" would be also good.
The NEST C++ API as defined in https://github.com/nest/nest-simulator/blob/master/nestkernel/nest.h should eventually also be part of the API documentation.
That seems alright if it's a page that helpfully lists the sub-items under there; otherwise I'd be happy to look into fixing this on a technical level; I don't think it'll be very difficult with Javascript.
contents.html is like a "sitemap" and should never be necessary to visit.
Agree, let's look at the theme and Javascript together after this PR.
100% on board with this! "Reference material" could be interchangable with "How NEST works", whichever title you prefer. In "PyNEST API", I feel like "PyNEST" is too much technical detail (it raises the question, what is this thing called PyNEST?) so I would suggest just going for "Python API" or "NEST API" (the latter slightly more compatible with the awaited C++ API additions). |
@clinssen I've simplified the main toc based on our discussion. I kept the model directory as a link, becasue I thought that might be something like the API users may want to explore. Please approve if you agree :) see: https://nest-test.readthedocs.io/en/new-doc-folder-structure/ |
@clinssen ping! |
This is shaping up really nicely! Just a few small points.
|
moved lower down
changed link fo rnow to the directory ( I figured it doesnt hurt to have it twice, evenutally that models page should contain more info)
It is actually in get help
put get help in community, although I think it's less intuitive to find help this way - but still ok for me
moved content around
yes, thanks for pointing this out, somehow I missed this option when looking at the config before
fixed
fixed
I tried to change this, but failed in my initial attempts, and I dont want to spend a lot of time on css - as the new theme should take its place soon (and by next release if all goes to plan). @clinssen I've addressed your comments, if satisfied please approve thanks! |
Many thanks! I'm approving already. Minor things to fix:
Perhaps you could double-check the RtD documentation build log; I'm not sure but it might emit warnings there in case of broken links or orphaned documents. |
@clinssen thanks for approving I will take note of your last comments and apply them to a different PR |
This PR reorganizes the documentation to improve findability of different topics, both in the source on GitHub and on Read the docs.
In the userdoc/ directory the guides/ have been removed in favour of more descriptive folders
New folders:
A new table of contents was also created for highlighting topics on Read the Docs:
You can see the structure output here: https://nest-test.readthedocs.io/en/new-doc-folder-structure/contents.html
In addition, I moved the developer docs back into userdoc/ because
See the output table of contents for the developer area here: https://nest-test.readthedocs.io/en/new-doc-folder-structure/devdoc/index.html
Please comment if you have suggestions for alternatives!