Update copyright file in debian directory #1324
Conversation
i'd suggest dropping debian/ altogehter, making an official debian package, file an RFP/ITP bug, close it via debian/changelog and that'll also you help easily have ubuntu copy your work (from debian) (officially distributing binaries of your software)
terhorstd
added
ZC: Infrastructure
debian/copyright
Outdated
|
|
||
| Files: librandom/* | ||
| Copyright: other people | ||
| License: other license | ||
|
|
||
| Files: debian/* | ||
| Copyright: 2019 The NEST Initiative <[email protected]> |
There was a problem hiding this comment.
2004, not 2019, see comment above.
There was a problem hiding this comment.
See above, this must also be 2004.
There was a problem hiding this comment.
@alexmyczko Please see my comments concerning copyright date and license.
debian/copyright
Outdated
| Source: https://github.com/nest/nest-simulator/ | ||
|
|
||
| Files: * | ||
| Copyright: 2004-2019 The NEST Initiative <[email protected]> |
There was a problem hiding this comment.
As a conscious policy decision, we always use 2004, the year of the first public release, as year of the NEST copyright, even for changes added later. So it should only be 2004 here.
There was a problem hiding this comment.
you can use the initial copyright, but debian uses whenever the source was started being written, to when the last change has been made to it, so 2004-2019 for debian/copyright is perfectly fine. and you shouldn't have that file at all anyways in a source tarball release, see top suggestion
There was a problem hiding this comment.
@alexmyczko Looking at https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#copyright-field, there seems no requirement to include a mail address on the copyright line, so it should be removed here. I also do not find elsewhere (https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile, https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#copyright) any explicit policy on copyright dates for Debian. Therefore, we should use 2004, and only 2004 here in keeping with general NEST Copyright policy.
debian/copyright
Outdated
|
|
||
| Files: * | ||
| Copyright: 2004-2019 The NEST Initiative <[email protected]> | ||
| License: GPL-2 |
There was a problem hiding this comment.
NEST license is GPL v2 or later, by choice of the user.
debian/copyright
Outdated
|
|
||
| Files: librandom/* | ||
| Copyright: other people | ||
| License: other license | ||
|
|
||
| Files: debian/* | ||
| Copyright: 2019 The NEST Initiative <[email protected]> |
There was a problem hiding this comment.
2004, not 2019, see comment above.
debian/copyright
Outdated
|
|
||
| Files: debian/* | ||
| Copyright: 2019 The NEST Initiative <[email protected]> | ||
| License: GPL-2 |
There was a problem hiding this comment.
GPL v2 or later, see above.
debian/copyright
Outdated
|
|
||
| Files: debian/* | ||
| Copyright: 2019 The NEST Initiative <[email protected]> | ||
| License: GPL-2 | ||
|
|
||
| License: GPL-2 |
There was a problem hiding this comment.
Hi @alexmyczko . Thank you for your help with that. I added my question and coments.
|
@alexmyczko: can you please have a look at the comments by @steffengraber and merge upstream to resolve the conflicts? Thanks! |
|
@alexmyczko: can you please resolve the conflicts in your branch, so we can merge this PR? Thanks! |
There was a problem hiding this comment.
@alexmyczko Please see my inline comments (remove mail address, 2004 as only copyright date).
debian/copyright
Outdated
| Source: https://github.com/nest/nest-simulator/ | ||
|
|
||
| Files: * | ||
| Copyright: 2004-2019 The NEST Initiative <[email protected]> |
There was a problem hiding this comment.
@alexmyczko Looking at https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#copyright-field, there seems no requirement to include a mail address on the copyright line, so it should be removed here. I also do not find elsewhere (https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile, https://www.debian.org/doc/manuals/maint-guide/dreq.en.html#copyright) any explicit policy on copyright dates for Debian. Therefore, we should use 2004, and only 2004 here in keeping with general NEST Copyright policy.
debian/copyright
Outdated
|
|
||
| Files: librandom/* | ||
| Copyright: other people | ||
| License: other license | ||
|
|
||
| Files: debian/* | ||
| Copyright: 2019 The NEST Initiative <[email protected]> |
There was a problem hiding this comment.
See above, this must also be 2004.
heplesser
removed
ZC: Infrastructure
|
Many thanks for this contribution and sorry for the messy review. In a group session during our ongoing hackathon, we addressed all open issues with this PR and came to the conclusion that we rather merge it as is instead of having this open for even longer. |
i'd suggest dropping debian/ altogehter, making an official debian package, file an RFP/ITP bug, close it via debian/changelog
and that'll also you help easily have ubuntu copy your work (from debian) (officially distributing binaries of your software)