Use vector of integer for per-thread bool indicators

nestkernel/CMakeLists.txt

@@ -23,7 +23,6 @@ set( nestkernel_sources
     archiving_node.h archiving_node.cpp
     clopath_archiving_node.h clopath_archiving_node.cpp
     common_synapse_properties.h common_synapse_properties.cpp
-    completed_checker.h completed_checker.cpp
     connection.h
     connection_label.h
     common_properties_hom_w.h
@@ -53,6 +52,7 @@ set( nestkernel_sources
     modelrange_manager.h modelrange_manager.cpp
     node.h node.cpp
     parameter.h parameter.cpp
+    per_thread_bool_indicator.h per_thread_bool_indicator.cpp
     proxynode.h proxynode.cpp
     recording_device.h recording_device.cpp
     pseudo_recording_device.h

nestkernel/connection_manager.cpp

@@ -94,9 +94,9 @@ nest::ConnectionManager::initialize()
   secondary_recv_buffer_pos_.resize( num_threads );
   sort_connections_by_source_ = true;
 
-  have_connections_changed_.resize( num_threads, true );
-  check_primary_connections_.resize( num_threads, false );
-  check_secondary_connections_.resize( num_threads, false );
+  have_connections_changed_.initialize( num_threads, true );
+  check_primary_connections_.initialize( num_threads, false );
+  check_secondary_connections_.initialize( num_threads, false );
 
 #pragma omp parallel
   {
@@ -555,17 +555,17 @@ nest::ConnectionManager::connect_( Node& s,
 
   // We do not check has_primary_connections_ and secondary_connections_exist_
   // directly as this led to worse performance on the supercomputer Piz Daint.
-  if ( not check_primary_connections_[ tid ] and is_primary )
+  if ( check_primary_connections_[ tid ].is_false() and is_primary )
   {
 #pragma omp atomic write
     has_primary_connections_ = true;
-    check_primary_connections_.set( tid, true );
+    check_primary_connections_[ tid ].set_true();
   }
-  else if ( not check_secondary_connections_[ tid ] and not is_primary )
+  else if ( check_secondary_connections_[ tid ].is_false() and not is_primary )
   {
 #pragma omp atomic write
     secondary_connections_exist_ = true;
-    check_secondary_connections_.set( tid, true );
+    check_secondary_connections_[ tid ].set_true();
   }
 }
 
@@ -1409,12 +1409,12 @@ nest::ConnectionManager::set_have_connections_changed( const thread tid )
   // Need to check if have_connections_changed_ has already been set, because if
   // we have a lot of threads and they all try to set the variable at once we get
   // performance issues on supercomputers.
-  if ( not have_connections_changed_[ tid ] )
+  if ( have_connections_changed_[ tid ].is_false() )
   {
     std::string msg =
       "New connections created, connection descriptors previously obtained using 'GetConnections' are now invalid.";
     LOG( M_WARNING, "ConnectionManager", msg );
-    have_connections_changed_.set( tid, true );
+    have_connections_changed_[ tid ].set_true();
   }
 }
 
@@ -1424,8 +1424,8 @@ nest::ConnectionManager::unset_have_connections_changed( const thread tid )
   // Need to check if have_connections_changed_ has already been set, because if
   // we have a lot of threads and they all try to set the variable at once we get
   // performance issues on supercomputers.
-  if ( have_connections_changed_[ tid ] )
+  if ( have_connections_changed_[ tid ].is_true() )
   {
-    have_connections_changed_.set( tid, false );
+    have_connections_changed_[ tid ].set_false();
   }
 }

nestkernel/connection_manager.h

@@ -30,14 +30,14 @@
 #include "manager_interface.h"
 
 // Includes from nestkernel:
-#include "completed_checker.h"
 #include "conn_builder.h"
 #include "connection_id.h"
 #include "connector_base.h"
 #include "node_collection.h"
 #include "nest_time.h"
 #include "nest_timeconverter.h"
 #include "nest_types.h"
+#include "per_thread_bool_indicator.h"
 #include "source_table.h"
 #include "target_table.h"
 #include "target_table_devices.h"
@@ -580,7 +580,7 @@ class ConnectionManager : public ManagerInterface
 
   //! True if new connections have been created since startup or last call to
   //! simulate.
-  CompletedChecker have_connections_changed_;
+  PerThreadBoolIndicator have_connections_changed_;
 
   //! Whether to sort connections by source node ID.
   bool sort_connections_by_source_;
@@ -589,13 +589,13 @@ class ConnectionManager : public ManagerInterface
   bool has_primary_connections_;
 
   //! Check for primary connections (spikes) on each thread.
-  CompletedChecker check_primary_connections_;
+  PerThreadBoolIndicator check_primary_connections_;
 
   //! Whether secondary connections (e.g., gap junctions) exist.
   bool secondary_connections_exist_;
 
   //! Check for secondary connections (e.g., gap junctions) on each thread.
-  CompletedChecker check_secondary_connections_;
+  PerThreadBoolIndicator check_secondary_connections_;
 
   //! Maximum distance between (double) spike times in STDP that is
   //! still considered 0. See issue #894