Count local devices for each thread #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
ZC: Kernel
|
@stinebuu Nice detective work :)! |
hakonsbm
suggested changes
Feb 26, 2020
Co-Authored-By: Håkon Bakke Mørk <[email protected]>
hakonsbm
approved these changes
Feb 27, 2020
jougs
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1409.
When creating devices, the number of local devices are counted. With NEST 3.0, the counting happens in parallell, but not in a thread safe way, so sometimes the threads might overwrite the variable. Then we get a problem with device ids, which in return can mess up spike delivery.
With this PR we now create a vector for the counting instead, so each thread keep track of the number of devices on the thread.
@lionelkusch could you check if this fixes your issue?