Correctly initialize result vector in music_rate_in_proxy::get_status() #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
requested changes
Mar 9, 2020
models/music_rate_in_proxy.h
Outdated
| @@ -167,7 +167,7 @@ class music_rate_in_proxy : public DeviceNode | |||
|
|
|||
| struct Buffers_ | |||
| { | |||
| double data_; | |||
| std::vector< double > data_; //!< The buffer for incoming data | |||
There was a problem hiding this comment.
@hakonsbm Based on your previous analysis this update makes sense, but I wonder if a smaller change, namely changing
( *d )[ names::data ] = DoubleVectorDatum( new std::vector< double >( B_.data_ ) );to
( *d )[ names::data ] = DoubleVectorDatum( new std::vector< double >( 1, B_.data_ ) );so that we correctly create a single-element vector, would be the safer approach here to just fix this problem?
There was a problem hiding this comment.
Done. But we should really have a test of this model.
There was a problem hiding this comment.
Indeed, would you create a follow-up issue for a proper review of this (and other music) proxies?
Based on review by @heplesser
heplesser
approved these changes
Mar 9, 2020
heplesser
added
ZC: Kernel
heplesser
changed the title
jakobj
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the type of the
Buffers_::data_variable in the MUSIC rate in proxy model.With the original uninitialised
double, passing the variable to thestd::vectorconstructor may lead to anstd::bad_allocerror. This can happen when the model tries to copy the vector withThis PR changes the variable to an
std::vector.Fixes #1449.