Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update globals to support execution of hpc_benchmark.py example #1810

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Update globals to support execution of hpc_benchmark.py example #1810

merged 1 commit into from
Oct 22, 2020

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Oct 21, 2020

The title has it all.

@jougs jougs added T: Enhancement New functionality, model or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 21, 2020
@jougs jougs added this to the NEST 3.0 milestone Oct 21, 2020
@jougs jougs requested review from babsey and hakonsbm October 21, 2020 18:25
@jougs jougs self-assigned this Oct 21, 2020
@jougs jougs requested review from steffengraber and removed request for hakonsbm October 21, 2020 18:33
@jougs
Copy link
Contributor Author

jougs commented Oct 21, 2020

@steffengraber: Can you please review this one quickly and recreate the Docker image once this one is merged? Thanks!

babsey
babsey approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@babsey babsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No problem with testing in examples.

@jougs jougs removed the request for review from steffengraber October 22, 2020 12:42
@jougs
Copy link
Contributor Author

jougs commented Oct 22, 2020

As the changes are minimal and @steffengraber is unavailable at the moment, I'm just merging without second review.

@jougs jougs merged commit e4d11d6 into nest:master Oct 22, 2020
@steffengraber
Copy link
Contributor

@jougs I was not available the past few days. The Docker image is rebuilt daily, so everything should be ok.

@jougs jougs deleted the nest-server branch August 31, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babsey babsey babsey approved these changes

Assignees

@jougs jougs

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation
Projects
PyNEST
Status: Done
Milestone
NEST 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jougs @steffengraber @babsey