-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make activation term exponent for I_NaP and I_T configurable in ht_neuron #1935
Conversation
configurable and improved NMDA channel documentation in HT notebook.
…nto fix-1189-ht-particles
…nto fix-1189-ht-particles
@ricardomurphy confirmed by email that the PR meets his expectations for a solution to #1189. |
…nto fix-1189-ht-particles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I just have a tiny suggestion.
Co-authored-by: Stine Brekke Vennemo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR fixes #1189.
The PR makes the activation term exponents in the HH-formulation of I_NaP and I_T of the ht_neuron configurable, keeping the previously hard-coded values as defaults. I decided not to enforce integer values but allow doubles since it is mathematically well-defined and permits greater flexibility to the modeller. Parameter names
N_NaP
andN_T
are chosen to match the "model details" notebook on the HT model.I also updated the model details notebook correspondingly and added additional information on the NMDA channel implementation based on a recent discussion in the mailing list.
@ricardomurphy Could you review if this matches your expectations? Github does not allow me to add you explicitly as a reviewer, unfortunately.