Make activation term exponent for I_NaP and I_T configurable in ht_neuron #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configurable and improved NMDA channel documentation in HT notebook.
heplesser
added
T: Enhancement
…nto fix-1189-ht-particles
…nto fix-1189-ht-particles
|
@ricardomurphy confirmed by email that the PR meets his expectations for a solution to #1189. |
…nto fix-1189-ht-particles
stinebuu
reviewed
Mar 3, 2021
Co-authored-by: Stine Brekke Vennemo <[email protected]>
terhorstd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1189.
The PR makes the activation term exponents in the HH-formulation of I_NaP and I_T of the ht_neuron configurable, keeping the previously hard-coded values as defaults. I decided not to enforce integer values but allow doubles since it is mathematically well-defined and permits greater flexibility to the modeller. Parameter names
N_NaPandN_Tare chosen to match the "model details" notebook on the HT model.I also updated the model details notebook correspondingly and added additional information on the NMDA channel implementation based on a recent discussion in the mailing list.
@ricardomurphy Could you review if this matches your expectations? Github does not allow me to add you explicitly as a reviewer, unfortunately.