Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make activation term exponent for I_NaP and I_T configurable in ht_neuron #1935

Merged
merged 5 commits into from
Mar 5, 2021

Conversation

heplesser
Copy link
Contributor

This PR fixes #1189.

The PR makes the activation term exponents in the HH-formulation of I_NaP and I_T of the ht_neuron configurable, keeping the previously hard-coded values as defaults. I decided not to enforce integer values but allow doubles since it is mathematically well-defined and permits greater flexibility to the modeller. Parameter names N_NaP and N_T are chosen to match the "model details" notebook on the HT model.

I also updated the model details notebook correspondingly and added additional information on the NMDA channel implementation based on a recent discussion in the mailing list.

@ricardomurphy Could you review if this matches your expectations? Github does not allow me to add you explicitly as a reviewer, unfortunately.

configurable and improved NMDA channel documentation in HT notebook.
@heplesser heplesser added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) good first issue Good for newcomers labels Feb 22, 2021
@heplesser heplesser requested a review from pnbabu February 22, 2021 13:02
@heplesser heplesser self-assigned this Feb 22, 2021
@heplesser
Copy link
Contributor Author

@ricardomurphy confirmed by email that the PR meets his expectations for a solution to #1189.

@heplesser heplesser requested a review from stinebuu March 3, 2021 11:16
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just have a tiny suggestion.

Co-authored-by: Stine Brekke Vennemo <[email protected]>
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@heplesser heplesser merged commit 2390f05 into nest:master Mar 5, 2021
@heplesser heplesser deleted the fix-1189-ht-particles branch March 22, 2021 10:59
@terhorstd terhorstd changed the title Activation term exponent for I_NaP and I_T configurable in ht_neuron Make activation term exponent for I_NaP and I_T configurable in ht_neuron Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Activation particles for NaP and T in ht_neuron
3 participants