Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of data exchanged in test to ensure stable operation. #1956

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

heplesser
Copy link
Contributor

This should fix #1944. It limits each individual value exchanged between individual MPI processes and the monitoring process to three symbols and thus avoids overflooding of the communication mechanism.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 1, 2021
@heplesser heplesser requested review from hakonsbm and stinebuu March 1, 2021 23:05
@heplesser heplesser self-assigned this Mar 1, 2021
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There is also a test_multiple_synapses.sli test, that basically does the same, but does not have spatial connections. Maybe we should decrease the data here as well? There are fewer connections in that test, so that is why it usually pass I think, but just in case something happens in the future?

@heplesser
Copy link
Contributor Author

@stinebuu I also updated test_multiple_synapses.sli as you suggested.

Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hakonsbm hakonsbm merged commit 4c7f620 into nest:master Mar 3, 2021
@heplesser heplesser deleted the fix-1944-unstable-test branch March 22, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize test_multiple_synapses_spatial_networks.sli
3 participants