Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port test_GetConnections from SLI-2-Py #2764

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Port test_GetConnections from SLI-2-Py #2764

merged 9 commits into from
Aug 31, 2023

Conversation

nicolossus
Copy link
Member

@nicolossus nicolossus commented May 3, 2023 •
edited
Loading

Port test_GetConnections.sli to Pytest.

@nicolossus nicolossus requested a review from janskaar June 30, 2023 13:02
@nicolossus nicolossus added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 24, 2023
@heplesser heplesser requested review from heplesser and removed request for janskaar August 30, 2023 08:40
heplesser
heplesser requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in person.

@nicolossus nicolossus requested a review from heplesser August 31, 2023 10:43
@heplesser heplesser merged commit 75718a8 into nest:master Aug 31, 2023
@nicolossus nicolossus deleted the port_test_GetConnections branch August 31, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolossus @heplesser