Add glif_psc_double_alpha model #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging recent changes
(They were used during development.)
Some of the parameters that are associated with the fast synaptic components get '_fast' added to their names. Pytest script added to test the GLIF model with double alpha synapses. A couple of test cases require adding extra parameters for the new glif_psc_double_alpha model, so they are added.
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
(They were used during development.)
Some of the parameters that are associated with the fast synaptic components get '_fast' added to their names. Pytest script added to test the GLIF model with double alpha synapses. A couple of test cases require adding extra parameters for the new glif_psc_double_alpha model, so they are added.
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
glif_psc_double_alpha.
heplesser
added
T: Enhancement
|
@shixnya @nicolossus No problem to proceed here. |
janskaar
approved these changes
Sep 8, 2023
clinssen
changed the title
clinssen
changed the title
clinssen
approved these changes
Sep 12, 2023
jessica-mitchell
requested changes
Sep 12, 2023
There was a problem hiding this comment.
Thanks @shixnya , I just a have couple of minor changes for the docs
Co-authored-by: jessica-mitchell <[email protected]>
Co-authored-by: jessica-mitchell <[email protected]>
|
Thank you so much, all, for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #2861 that was accidentally closed.
The most recent change contains rebasing to the updated upstream/master, and fixing one of the newly added test cases in the updates.
Hopefully, this version passes all of the tests.