-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glif_psc_double_alpha model #2925
Conversation
Merging recent changes
(They were used during development.)
Some of the parameters that are associated with the fast synaptic components get '_fast' added to their names. Pytest script added to test the GLIF model with double alpha synapses. A couple of test cases require adding extra parameters for the new glif_psc_double_alpha model, so they are added.
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: clinssen <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
(They were used during development.)
Some of the parameters that are associated with the fast synaptic components get '_fast' added to their names. Pytest script added to test the GLIF model with double alpha synapses. A couple of test cases require adding extra parameters for the new glif_psc_double_alpha model, so they are added.
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
Co-authored-by: Nicolai Haug <[email protected]>
glif_psc_double_alpha.
@shixnya @nicolossus No problem to proceed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shixnya , I just a have couple of minor changes for the docs
Co-authored-by: jessica-mitchell <[email protected]>
Co-authored-by: jessica-mitchell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Thank you so much, all, for your help! |
Continuation of PR #2861 that was accidentally closed.
The most recent change contains rebasing to the updated upstream/master, and fixing one of the newly added test cases in the updates.
Hopefully, this version passes all of the tests.