Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add line number to error message #3343

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Add line number to error message #3343

merged 4 commits into from
Dec 16, 2024
+101 −43

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Oct 21, 2024

It adds ErrorHandler to use line number of error message for NEST Desktop.

@babsey babsey added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Nov 4, 2024
@babsey
Copy link
Contributor Author

babsey commented Nov 14, 2024 •
edited
Loading

Friendly ping!

@babsey babsey requested review from nicolossus and clinssen and removed request for nicolossus December 11, 2024 12:55
clinssen
clinssen reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just two small comments!

@suku248 suku248 requested a review from otcathatsya December 16, 2024 11:00
@suku248 suku248 merged commit c201d67 into nest:master Dec 16, 2024
24 checks passed
@babsey babsey deleted the error-lineno branch December 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otcathatsya otcathatsya otcathatsya approved these changes

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
PyNEST
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@babsey @otcathatsya @clinssen @suku248