Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if dot binary exists #3404

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Check if dot binary exists #3404

merged 3 commits into from
Feb 10, 2025

Conversation

med-ayssar
Copy link
Contributor

Fixes #3390

@med-ayssar
Copy link
Contributor Author

@heplesser, could you also quickly review this.

heplesser
heplesser approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 10, 2025
@heplesser
Copy link
Contributor

Small fix to test, therefore merging with single review.

@heplesser heplesser merged commit 36d182e into nest:master Feb 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation
Projects
Build system and CI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualization test crashes if dot not installed
2 participants
@med-ayssar @heplesser