Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent association #143

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Fix parent association #143

merged 5 commits into from
Dec 19, 2024

Conversation

aedwardstx
Copy link
Collaborator

@aedwardstx aedwardstx commented Dec 19, 2024 •
edited
Loading

Fix incorrect parent association when creating the delta subtree under _config_to_get_to_right().

Other changes:

  • poetry update
  • Add test to ensure parent identities of remediation HConfig objects match
  • Fix lint raw string issue

@aedwardstx aedwardstx added the bug Something isn't working label Dec 19, 2024
@aedwardstx aedwardstx requested a review from jtdub December 19, 2024 14:30
@aedwardstx aedwardstx self-assigned this Dec 19, 2024
jtdub
jtdub approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jtdub jtdub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aedwardstx aedwardstx merged commit 7feffeb into netdevops:master Dec 19, 2024
4 checks passed
@aedwardstx aedwardstx deleted the fix_parent_association branch December 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtdub jtdub jtdub approved these changes

Assignees

@aedwardstx aedwardstx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aedwardstx @jtdub