Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sorted function to natural sort based on child.text value #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hier_config/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from itertools import chain
from logging import getLogger
from typing import TYPE_CHECKING, Optional, TypeVar, Union
from natsort import natsorted

from .children import HConfigChildren
from .exceptions import DuplicateChildError
Expand Down Expand Up @@ -109,7 +110,7 @@ def add_deep_copy_of(

def all_children_sorted(self) -> Iterator[HConfigChild]:
"""Recursively find and yield all children sorted at each hierarchy."""
for child in sorted(self.children):
for child in natsorted(self.children, key=lambda child: child.text):
yield child
yield from child.all_children_sorted()

Expand Down