Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move xxxNornirNutsContext.nornir_filter up to base class #51

Closed
lucmurer opened this issue Nov 25, 2021 · 0 comments · Fixed by #53
Closed

move xxxNornirNutsContext.nornir_filter up to base class #51

lucmurer opened this issue Nov 25, 2021 · 0 comments · Fixed by #53
Assignees
@lucmurer
Labels
refactor
Milestone
Release 3.0.2

Comments

@lucmurer
Copy link
Contributor

The xxxNornirNutsContext.nornir_filter() function is implemented the same in all test classes subclassing NornirNutsContext. So it can be moved up directly to the class NornirNutsContext.
If a special nornir_filter() is needed in future test classes it can still be overwritten in the respective test class.
@lucmurer lucmurer added this to the Release 3.0.2 milestone Nov 25, 2021
@lucmurer lucmurer self-assigned this Nov 25, 2021
lucmurer pushed a commit that referenced this issue Nov 25, 2021
#51: Move method nornir_filter up to NornirNutsContext, since it was …
94ba6ca 
…the same in all test-classes that subclassed it.
lucmurer pushed a commit that referenced this issue Nov 29, 2021
#51: Also remove the special nornir_filter method from the tests.
11bf432
@lucmurer lucmurer linked a pull request Nov 29, 2021 that will close this issue
51 move xxx nornir nuts context.nornir filter up to base class #53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucmurer lucmurer

Labels
refactor
Projects
None yet
Milestone
Release 3.0.2
Development

Successfully merging a pull request may close this issue.

51 move xxx nornir nuts context.nornir filter up to base class network-unit-testing-system/nuts
1 participant
@lucmurer