Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FEC in Fortinet 7.4 get system interface physical #2036

Merged

Conversation

mjbear
Copy link
Collaborator

@mjbear mjbear commented Feb 22, 2025

resolves #2032 and supersedes #2033

Some big changes to the template after building off of @yone2ks's PR

  • Major: Record on port heading since older output does not have FEC_cap at the end of the section
  • Minor: Make the optional Mbps regex a more common syntax
  • Minor: Add FEC and FEC_CAP capture groups

@mjbear mjbear marked this pull request as ready for review February 22, 2025 13:06
@jvanderaa
Copy link
Contributor

@mjbear I think I may need some of your eyes on this one!

@mjbear mjbear force-pushed the fortinet_get_sys_int_phys_pr2033 branch from 5ef90e1 to 38141d5 Compare February 26, 2025 03:31
@mjbear
Copy link
Collaborator Author

mjbear commented Feb 26, 2025

@mjbear I think I may need some of your eyes on this one!

Got it.
Smoothed out those merge conflicts. 😎

@jvanderaa jvanderaa merged commit c497027 into networktocode:master Feb 27, 2025
10 checks passed
@mjbear mjbear deleted the fortinet_get_sys_int_phys_pr2033 branch February 27, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants