Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cisco_nxos_show_nve_vni.textfsm #2067

Merged
merged 5 commits into from
Mar 14, 2025

Conversation

julien-lebreton
Copy link
Contributor

Add S-ND line and Hybrid mode line
Those 2 lines are mandatory to work properly with version 10.3.4a of NX-OS

Add S-ND line and Hybrid mode line
@mjbear
Copy link
Collaborator

mjbear commented Feb 27, 2025

@julien-lebreton
We also need test data included in this PR.

As long as you put the raw data in the correct spot, you can use helper scripts to generate the structured data (yaml).

The test data is necessary so that we can make sure the template is backwards compatible in the future when more changes are needed.

@mjbear mjbear self-assigned this Mar 4, 2025
@mjbear mjbear added the status: action required This issue requires additional information to be actionable label Mar 4, 2025
@mjbear mjbear marked this pull request as draft March 11, 2025 01:38
@mjbear
Copy link
Collaborator

mjbear commented Mar 11, 2025

As time permits I plan to build a topology to get raw output ... if Julien hasn't responded by then. 🙂

@julien-lebreton julien-lebreton marked this pull request as ready for review March 13, 2025 20:44
@julien-lebreton julien-lebreton requested a review from mjbear as a code owner March 13, 2025 20:44
@julien-lebreton
Copy link
Contributor Author

update with raw data in tests/cisco_nxos/show_nve_vni directory

@mjbear
Copy link
Collaborator

mjbear commented Mar 14, 2025

update with raw data in tests/cisco_nxos/show_nve_vni directory

Hello @julien-lebreton

Thank you for submitting this PR and adding test data!
You saved me a step in getting test data. 😆

You might see I made changes.

Since the old test data had various VRF names and what not there is some merit in retaining it. This enables us to have both the old and new data to run through the GH Actions CI validating no regressions occur.

Update: Plus the structured data (keys) got reordered in alphabetical order by the helper scripts used to generate the structured data.

@mjbear mjbear removed the status: action required This issue requires additional information to be actionable label Mar 14, 2025
@mjbear mjbear merged commit db8b11f into networktocode:master Mar 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants