Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving template for Huawei SmartAX: display_ont_wlan-status_0_1 #2070

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improving template for Huawei SmartAX: display_ont_wlan-status_0_1 #2070

wants to merge 4 commits into from

Conversation

evilmonkey19
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request (Only one template at a time is allowed)
  • Bugfix Pull Request
  • Additional Testing
  • Docs Pull Request
COMPONENT
SUMMARY

@mjbear mjbear assigned mjbear and unassigned mjbear Mar 12, 2025
@mjbear mjbear self-requested a review as a code owner March 13, 2025 02:34
@mjbear mjbear self-assigned this Mar 13, 2025
@mjbear mjbear added the WIP Work in Progress label Mar 13, 2025
@mjbear
Copy link
Collaborator

mjbear commented Mar 13, 2025

I think I'd like to swap out some of the \s* regex for \s+ where we can tell in the raw output there is one or more spaces.

(Hence the WIP label.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

@mjbear mjbear Awaiting requested review from mjbear mjbear is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mjbear mjbear

Labels
WIP Work in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evilmonkey19 @mjbear