Regenerate all hp comware disp int br test data #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
Actually the likely cause is PR #1977 has been around for a while and likely needs rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for mistake in #1964 where it would appear all the test data was not regenerated.
(Only the new test data was generated and present.)
Edit: I suspect the GH Actions needed re-run in order to catch the changes in test data. Or this test data was new and the above mentioned PR needed rebased. 😮💨 Crisis averted.