Template: spanning-tree root for cisco ios #2077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmantitu
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa and
mjbear
as code owners
|
Hello @osmantitu We also need test data included in this PR. As long as you put the raw data in the correct spot, you can use helper scripts to generate the structured data (yaml). The test data is necessary so that we can make sure the template is backwards compatible in the future when more changes are needed. 🎯 Please respond back if there are any questions. Thank you! |
mjbear
added
the
status: action required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template for parsing output of show spanning-tree root cmd of Cisco ios devices.