Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple BEFORE/AFTER blocks of same type in a mod file. #1722

Merged
merged 3 commits into from
Mar 26, 2022

Conversation

nrnhines
Copy link
Member

@nrnhines nrnhines commented Mar 22, 2022

Same extension as BlueBrain/CoreNeuron#790

Includes modified coreneuron_modtests::test_pointer_py_cpu

  • Merge CoreNEURON PR and update submodule before merge

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (require coreneuron merge).

@nrnhines : should this go into 8.1?

@nrnhines
Copy link
Member Author

@pramodk should this go into 8.1
I don't think so. We can let the merge wait til the 8.1 release branch and tag is created.

@codecov-commenter
Copy link

Codecov Report

Merging #1722 (41f5db4) into master (30b9eac) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
- Coverage   45.34%   45.30%   -0.04%     
==========================================
  Files         551      551              
  Lines      111219   111225       +6     
==========================================
- Hits        50431    50393      -38     
- Misses      60788    60832      +44     
Impacted Files Coverage Δ
src/nrncvode/netcvode.cpp 66.49% <ø> (ø)
src/nrnoc/init.cpp 87.90% <100.00%> (+0.07%) ⬆️
src/nrnoc/multicore.cpp 85.34% <100.00%> (+0.07%) ⬆️
src/nrnmpi/bbsmpipack.cpp 82.56% <0.00%> (-10.77%) ⬇️
src/parallel/bbsclimpi.cpp 50.00% <0.00%> (-8.14%) ⬇️
src/parallel/bbssrvmpi.cpp 42.16% <0.00%> (-6.03%) ⬇️
src/parallel/bbs.cpp 74.26% <0.00%> (-1.69%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pramodk
Copy link
Member

pramodk commented Mar 26, 2022

I am going to ignore docs PR failure because its related to #1731.

@pramodk pramodk merged commit b59e6de into master Mar 26, 2022
@pramodk pramodk deleted the hines/bamult branch March 26, 2022 13:38
@alexsavulescu alexsavulescu mentioned this pull request Jun 29, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants