Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cython>=3 and remove cython<3 pin. #3028

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Support cython>=3 and remove cython<3 pin. #3028

merged 5 commits into from
Aug 13, 2024

Conversation

kbvw
Copy link
Contributor

@kbvw kbvw commented Aug 5, 2024

Fixes #2435

Copy link

✔️ 97a56b2 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@kbvw kbvw requested a review from 1uc August 5, 2024 15:13
@kbvw kbvw mentioned this pull request Aug 5, 2024
1uc
1uc previously approved these changes Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (cdabc3c) to head (87a9524).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3028   +/-   ##
=======================================
  Coverage   67.27%   67.28%           
=======================================
  Files         571      571           
  Lines      104916   104909    -7     
=======================================
  Hits        70585    70585           
+ Misses      34331    34324    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc changed the title Fix RXD issues resulting from cython>=3 and remove cython<3 pin Support cython>=3 and remove cython<3 pin. Aug 6, 2024
@kbvw kbvw force-pushed the rxd_cython3 branch 2 times, most recently from c6d13dd to ae2db1a Compare August 6, 2024 14:31
@bbpbuildbot

This comment has been minimized.

@1uc 1uc dismissed their stale review August 7, 2024 08:21

CI went red.

Copy link

✔️ fcb8af5 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ c8221ee -> Azure artifacts URL

Copy link

Copy link

✔️ 87a9524 -> Azure artifacts URL

@alkino alkino merged commit 61dfd7c into master Aug 13, 2024
38 checks passed
@alkino alkino deleted the rxd_cython3 branch August 13, 2024 09:58
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible compromise between RXD using dlsym (hence language="c") and MUSIC that uses std::vector (therefore language="c++").

mgeplf pushed a commit that referenced this pull request Aug 19, 2024
* Change Cython language setting to C instead of C++ except for MUSIC
nrnhines added a commit that referenced this pull request Jan 23, 2025
nrnhines added a commit that referenced this pull request Jan 23, 2025
JCGoran added a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cython 3.0 support
5 participants