Fix Windows CI #3252
Merged
Fix Windows CI #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the (virtual) package mingw-w64-x86_64-python3-setuptools doesn't exist anymore (https://packages.msys2.org/packages/mingw-w64-x86_64-python3-setuptools is empty), but mingw-w64-x86_64-python3-setuptools does exist (and was earlier providing the actual package for the former).
|
1uc
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3252 +/- ##
==========================================
- Coverage 67.08% 67.08% -0.01%
==========================================
Files 569 570 +1
Lines 111079 111066 -13
==========================================
- Hits 74520 74511 -9
+ Misses 36559 36555 -4 ☔ View full report in Codecov by Sentry. |
|
✔️ 7a602ab -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the (virtual) package
mingw-w64-x86_64-python3-setuptoolsdoesn't exist anymore (https://packages.msys2.org/packages/mingw-w64-x86_64-python3-setuptools is gone), butmingw-w64-x86_64-python-setuptoolsdoes exist (and was earlier providing the actual package for the former).Could this happen to all of the
python3*packages in the build script? Maybe, but they're not broken at the moment, so minimal fix it is.