Patch turndown #105
Merged
Patch turndown #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfulb
pushed a commit
to mfulb/docs-website
that referenced
this pull request
Sep 21, 2022
* Addressed the 64-bit valgrind issue. * Changed the workflow to show 7.x builds as well. * Disabled valgrind tests for 8.0 on 64-bit in the CI as now that the linking issue is resolved, it has surfaced a memory issue that needs further investigation. * Better to have 7.4 as non-zts example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patches
turndownto include the changes that fix the issue whereiframes are removed from the output due to how the library parses blank nodes.This uses patch-package to patch the changes from mixmark-io/turndown#326 into the code. This will be safe to remove once turndown releases a new version with this fix.