Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-267606 test: add dynamodb to lock terraform state #1868

Closed

Conversation

rubenruizdegauna
Copy link
Contributor

This PR:

  • Adds dynamodb table to lock terraform state
  • Fixes install-requirements used in ec2 tool
  • Removes unused playbooks

#########################################
terraform {
backend "s3" {
bucket = "infra-agent-terraform"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using another bucket? I think that we could reuse the same bucket

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, no specific reason. Moved to pipeline bucket 94fb83e

@@ -0,0 +1,13 @@

// DynamoDB Table to store Terraform State Lock
resource "aws_dynamodb_table" "dynamodb-terraform-state-lock" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to update the oidc IAM access here or somewhere here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.
I have added it here newrelic/fargate-runner-action#34

and added to this repo here dedb40a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm thinking that this should be conditional... moving it to a draft to give it a proper thought

@rubenruizdegauna rubenruizdegauna marked this pull request as draft May 21, 2024 13:53
@rubenruizdegauna rubenruizdegauna force-pushed the NR-267606_infra_alerts_add_dynamo_lock branch from f67b66d to 643c9a0 Compare May 29, 2024 16:20
@rubenruizdegauna
Copy link
Contributor Author

We will not work on this for now.

@rubenruizdegauna rubenruizdegauna deleted the NR-267606_infra_alerts_add_dynamo_lock branch December 17, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants