NR-267606 test: add dynamodb to lock terraform state #1868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenruizdegauna
requested review from
a team,
alvarocabanas,
gsanchezgavier and
DavSanchez
test/terraform/terraform.backend.tf
Outdated
| ######################################### | ||
| terraform { | ||
| backend "s3" { | ||
| bucket = "infra-agent-terraform" |
There was a problem hiding this comment.
why using another bucket? I think that we could reuse the same bucket
There was a problem hiding this comment.
Good point, no specific reason. Moved to pipeline bucket 94fb83e
test/terraform/main.tf
Outdated
| @@ -0,0 +1,13 @@ | |||
|
|
|||
| // DynamoDB Table to store Terraform State Lock | |||
| resource "aws_dynamodb_table" "dynamodb-terraform-state-lock" { | |||
There was a problem hiding this comment.
Indeed.
I have added it here newrelic/fargate-runner-action#34
and added to this repo here dedb40a
There was a problem hiding this comment.
But I'm thinking that this should be conditional... moving it to a draft to give it a proper thought
rubenruizdegauna
force-pushed
the
NR-267606_infra_alerts_add_dynamo_lock
branch
from
f67b66d to
643c9a0
Compare
|
We will not work on this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: