-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR-267606 test: add dynamodb to lock terraform state #1868
Conversation
test/terraform/terraform.backend.tf
Outdated
######################################### | ||
terraform { | ||
backend "s3" { | ||
bucket = "infra-agent-terraform" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why using another bucket? I think that we could reuse the same bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, no specific reason. Moved to pipeline bucket 94fb83e
test/terraform/main.tf
Outdated
@@ -0,0 +1,13 @@ | |||
|
|||
// DynamoDB Table to store Terraform State Lock | |||
resource "aws_dynamodb_table" "dynamodb-terraform-state-lock" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
I have added it here newrelic/fargate-runner-action#34
and added to this repo here dedb40a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I'm thinking that this should be conditional... moving it to a draft to give it a proper thought
f67b66d
to
643c9a0
Compare
We will not work on this for now. |
This PR: