Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace broken trigger duration string before prasing #10852

Closed
wants to merge 1 commit into from

Conversation

SebastianKrupinski
Copy link
Contributor

Resolves: #10788

@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-10788-trigger-duration branch from 1b72f6e to 7ec5b50 Compare March 11, 2025 16:53
@kesselb
Copy link
Contributor

kesselb commented Mar 11, 2025

The reason for #10788 is therefore nextcloud/calendar-js#790?

Can you still reproduce the issue on main and if yes, is it a different error message? If so, then the patch for calendar-js did not cover all cases.

Could you please invite Richard and me to such an outlook event?

@SebastianKrupinski
Copy link
Contributor Author

The reason for #10788 is therefore nextcloud/calendar-js#790?

Ah... I didn't know that you had already been working on this.

Can you still reproduce the issue on main and if yes, is it a different error message? If so, then the patch for calendar-js did not cover all cases.

Yes, I reproduced it yesterday, while looking in to another issue.

Could you please invite Richard and me to such an outlook event?

Sure.

@kesselb
Copy link
Contributor

kesselb commented Mar 11, 2025

Your invitation works for me.

Could you retry after running git switch main; git pull; npm ci; npm run dev?

@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Mar 11, 2025

Your invitation works for me.

Could you retry after running git switch main; git pull; npm ci; npm run dev?

Npm CI made the difference. I don't usually run this.

All good now, closing this PR.

@kesselb
Copy link
Contributor

kesselb commented Mar 11, 2025

@SebastianKrupinski 👍

So it's fixed for main and stable4.3, but not for stable4.2. I assume it's possible to also backport the calendar-js update to stable4.2, but that's something for @ChristophWurst to decide. If backporting it not an option, we can still apply this change to stable4.2.

@ChristophWurst
Copy link
Member

Let's backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Microsoft 365 appointment invitations not working
3 participants