[Vue Rewrite] Clean up indentation + linting rules

[devlinjunker]

PR to Cleanup Linting rules + Use Typescript in all Components so far

• follows [Vue Rewrite] Enable Typescript Vue Components #1831
• indentation: use tabs rather than spaces
• verify indentation in vue html templates
• remove node/no-unpublished-import rule because no more vue-property-decorator library
• no linting errors

you can see the dev work done here

• [Vue Rewrite] Fix Linting Rules + Lint Warnings + Update Indentation  devlinjunker/news#33

Up Next:

• Components to Typescript PR
• Add Unit Tests to run with npm run test
• Add Vuex Store (see 58a196b for preview)
• Add Proper Routing (see devlinjunker/news@vue-version...devlinjunker:vue-routes for preview)

[SMillerDev]

I'd prefer if this was split into two reviews here too.

[devlinjunker]

I moved the branch pointer back 2 commits so it doesn't include the Component to typescript changes.

This PR is now just for cleaning up indentation and linting and I have created a new PR for moving the component files to typescript: #1922

[SMillerDev]

Why move to tabs by the way? Because all the other code in this repo uses spaces.

[devlinjunker]

@SMillerDev I was just following the Vue style conventions rather than add a rule to overwrite them. If you think it makes sense to keep the consistency in the entire repo then I can re-add the:

rules: {
        'vue/html-indent': 'off',
        indent: ['error', 4],
    },

to the .eslintrc file and run the lint again

[Grotax]

Looks ok to me, I don't mind tabs or spaces as long as it is consistent.
And if tabs is the default for this linter then we can stick to that.

Modern IDEs detect that automatically anyway.

[anoymouserver]

I agree with Grotax that tabs are ok too, as long as it's consistent per file type.
However, please also modify the .editorconfig, otherwise the next IDE/editor would simply change it back to spaces.

Remove js from here

news/.editorconfig

Lines 8 to 11 in 3ff51b5

	[*.{js,php,html}]
	indent_style = space
	indent_size = 4
	charset = utf-8

... and add a block like this

[*.{js,ts,vue}]
indent_style = tab
indent_size = 4
charset = utf-8

[devlinjunker]

Updated the .editorconfig and those remaining spaces in the vue html @anoymouserver

[devlinjunker]

after this is merged, we can move on to #1922

and I am currently working on adding unit tests for the existing components. See devlinjunker#56 for the WIP changes so far