-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue Rewrite] Upmerge Recent Changes #1982
[Vue Rewrite] Upmerge Recent Changes #1982
Conversation
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look on the changes and looks ok.
Most changes affect the language files which can be ignored.
I think the main review needs to happen once we merge the vue rewrite into master
ah the tests should be fixed of course :) |
Signed-off-by: Devlin Junker <[email protected]>
hmm... strange.. I had to use node version 18 to update the package-lock file although the workflows seem to only be using 16 I'm noticing a lot of the translations were removed in this PR (so removed from |
Translations are not managed by this repository so we automatically receive whatever translations are created. I don't monitor it |
oh alright, sounds good then any idea what's going on with these integration tests for php 8.2? https://github.com/nextcloud/news/actions/runs/3438626164/jobs/5735094897 I'll clean up the linting errors tonight |
You can ignore the PHP 8.2 tests. NC does not support it yet, but it might be as soon as there is an official 8.2 release later this year. |
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
I didn't verify the linting fixes last night before pushing but I did this morning and they should be working now sorry about that! |
seems like we're good to merge this one now and I'll start on the next steps in this PR |
NOTE: Please Review this PR carefully... lots of changes!
Related to #748 and #1880
Follows #1968
Upmerge Recent Changes from
master
Testing Completed
Verified that App Builds with
make
Verified that Admin Settings Page Loads on localhost (NC 25)

Verified that App loads on localhost (NC 25)

Verified that Jest Unit Tests Pass

Up Next