Fix audio player floating when scrolling #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ManuelSailer <[email protected]>
SMillerDev
approved these changes
Apr 17, 2023
Signed-off-by: Manuel Sailer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix audio player floating when scrolling in NC25+.
Using the #app-content.nc-major-version-gte-25 class introduced in #2196 in CSS and the NC_MAJOR_VERSION constant in JavaScript to apply (and limit) changes to NC versions >= 25.
Currently there are no changes regarding the overlapping navigation toggle icon on screens < 1024 pixels width as the expected behavior should be discussed before.
Checklist