Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 21.2.0-beta4 #2209

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Release 21.2.0-beta4 #2209

merged 1 commit into from
Apr 23, 2023

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Apr 20, 2023

  • Resolves: n/a

Summary

Fixed

Checklist

Fixed
- Fix audio player floating when scrolling in NC25+ (#2142)
- Fix sorting of folder names in select when adding subscription (#2090)

Signed-off-by: Benjamin Brahmer <[email protected]>
@SMillerDev
Copy link
Contributor

Should we be worried about the update check?

@Grotax
Copy link
Member Author

Grotax commented Apr 20, 2023

No I don't think so, I didn't consider when I developed them that the cloud might be faster at executing these statements depending on the load compared to my setup.

I think what happens sometimes is that the PHP process is still working in the background while the script is already running the next command.

Something that would probably not happen in real or just lead to the user trying it again.

So I guess I need to go through it and add safety seelp commands to make sure that PHP had enough time to think about the request...

I have seen this one fail before and then after rerun it's green

@SMillerDev
Copy link
Contributor

Let's give it a rerun

@Grotax
Copy link
Member Author

Grotax commented Apr 20, 2023

I did already :) the only failed check is the PHP linter. I currently don't have enough time to do the release, will try this weekend

@Grotax Grotax merged commit 1fc1e51 into master Apr 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the release/21.2.0-beta4 branch April 23, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants