Use HTTP compression for downloads #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as we use Feed-io < 6, we always use Guzzle (with Feed-io 6, we need to choose a [HTTPlug](https://httplug.io/) library ourselves). Guzzle [supports](https://docs.guzzlephp.org/en/stable/request-options.html#decode-content) transparently decompressing gzip or deflate compressed responses, which is enabled by default. Feed-io does this [by default](alexdebril/feed-io@ffef9ea), but as we override the headers, we have to add a fitting `Accept-Encoding` header as well. Previously, my feed collection caused up to 45.9 MB download traffic per cronjob, with this commit it is as low as 23.6 MB. Signed-off-by: Mynacol <[email protected]>
Mynacol
force-pushed
the
support-compression
branch
from
2199150 to
6636ac9
Compare
SMillerDev
approved these changes
Jun 21, 2023
|
cool, thanks :) |
Grotax
added a commit
that referenced
this pull request
Jul 23, 2023
Changed - Support deflate and gzip compression for HTTP response bodies (#2269) - Broke apart old FAQ into different guides. Deprecated old FAQ (#2285) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jul 23, 2023
Changed - Support deflate and gzip compression for HTTP response bodies (#2269) - Broke apart old FAQ into different guides. Deprecated old FAQ (#2285) Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Jul 23, 2023
Changed - Support deflate and gzip compression for HTTP response bodies (#2269) - Broke apart old FAQ into different guides. Deprecated old FAQ (#2285) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As long as we use Feed-io < 6, we always use Guzzle (with Feed-io 6, we need to choose a HTTPlug library ourselves). Guzzle supports transparently decompressing gzip or deflate compressed responses, which is enabled by default.
Feed-io does this by default, but as we override the headers, we have to add a fitting
Accept-Encodingheader as well.Previously, my feed collection caused up to 45.9 MB download traffic per cronjob, with this commit it is as low as 23.6 MB.
Checklist