Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Sidebar Feed/Folder Actions #2354

Merged
merged 11 commits into from
Sep 20, 2023

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Sep 17, 2023

Related to #748

Follows #2346

🗒️ Summary

  • Add component for Feed actions that updates the Feed setting properties (rename, pin, order, full text, update mode, delete, open feed url)
  • Add methods in Sidebar for Folder actions (rename, delete, mark read)
  • Add Store Actions/Mutations and Service methods for these actions

✅ Checklist

- [ ] Changelog entry added for all important changes. (Can we add the skip-changelog label to prevent the check for changelog? )

📷 Visual

Feed Actions:
feed actions

Folder Actions:
folder actions

➡️ Up Next

MVP:

  • subscribe_to parameter for adding new feeds
  • Share Menu
  • Warning and Error Messages (Token Expired/Error during backend request)
  • Audio/Video Feed Items
  • Mobile friendly layout (since we are no longer displaying the feed item just in the list)
  • Update Documentation for Front End

questionable

  • addArticleAction Plugin API
  • Quick access to Settings
    • Keyboard Navigation?
    • Reverse Order (Oldest to Newest)
    • Upload/Download Subscriptions/Articles
    • Mark on Scroll?
    • Compact/Expanded View?

Improvements:

  • Improve Explore Page?
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay (this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)

Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
@Grotax Grotax merged commit 2ebd898 into nextcloud:vue-rewrite Sep 20, 2023
@Grotax
Copy link
Member

Grotax commented Sep 20, 2023

Hey, I just tried this. Seems like there is something missing I only get the menu for folders, feeds only have the delete button. I build the app with make.

I will also check if maybe I made a mistake.

test-news.mp4

@devlinjunker
Copy link
Contributor Author

devlinjunker commented Sep 22, 2023

oh thanks @Grotax ! I noticed this the other day too.. not sure where the bug is, but I'll look into it!

On an aside, does anyone use a News Plugin, or do many exist out there? Should I be concerned about making sure any existing ones work, or try to redo the plugin api in an "improvement" rather than in the MVP?

Also how much of this settings list is important for an initial rewrite release? feedback from any users or anyone really is welcome (@anoymouserver @SMillerDev)

- Keyboard Navigation?
- Reverse Order (Oldest to Newest)
- Upload/Download Subscriptions/Articles
- Mark on Scroll?
- Compact/Expanded View?

I've updated the Up Next section to identify these questions, i'll continue working on the MVP section (and this bug) while I figure out the answer to the above

@Grotax
Copy link
Member

Grotax commented Sep 26, 2023

I'm not aware of any active plugins, since I maintain this app there was nothing of interest.
I don't think that we need to support the old api, you can re-build it from scratch, I think it's also a less important feature.

The other features I would rank them like this.

  1. Keyboard Navigation
  2. Mark on Scroll
  3. Reverse Order
  4. Upload/Download
  5. More Views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants