-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue Rewrite] Share Article Component #2361
Conversation
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Because of the merge there is a conflict in this PR now. Great work so far, watching the progress you make is nice. |
Signed-off-by: devlinjunker <[email protected]>
Fixed the conflict! Thanks! It has been satisfying, hopefully it will be easier to maintain and contribute to now... and I agree we're almost ready for a release! Most important to do still is make sure it works well on mobile, as that's how I scroll through the feeds on my instance usually π I am going to try to wrap up all of the tasks listed in the |
Signed-off-by: Devlin Junker <[email protected]>
I think I fixed the static analysis PHPCS error on this branch, once the workflows re-run and have (hopefully) passed can we merge this in? |
failing checks are related to the dbal dependency, so just merging this |
Related to #748
Follows #2360
ποΈ Summary
β Checklist
- [ ] Changelog entry added for all important changes.(Can we add theskip-changelog
label to prevent the check for changelog? )π· Visual
Share Component:

Appearing when Shared User logs in:

β‘οΈ Up Next
MVP:
?selected=<id>
url query parameter to store and parse which Feed Item is displayed inFeedItemDisplay
(this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)Following Rewrite Release Improvements:
addArticleAction
Plugin API