Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue Rewrite] Basic Error Handling and Display #2370

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

devlinjunker
Copy link
Contributor

@devlinjunker devlinjunker commented Oct 4, 2023

Related to #748

🗒️ Summary

  • Add Basic JS Error Display in top right corner
    • use axios interceptors to set app error when backend request failures
    • use Vue config to set app error when Vue Rendering throws error
  • Also added a little cleanup of types throughout the project (mentioned in comment below)

✅ Checklist

- [ ] Changelog entry added for all important changes.

📷 Visual

Error:
Screenshot 2023-10-04 at 3 12 56 PM

➡️ Up Next

  • Mobile friendly layout (since we are no longer displaying the feed item below the row) (WIP)
  • Settings in Sidebar (@scottdotau may be taking this one)
    • Component
    • Backend Requests + Application Behavior Changes
      • Keyboard Navigation
      • Mark on Scroll
      • Reverse Order (Oldest to Newest)
      • Upload/Download Subscriptions/Articles
  • Fix Explore Page (WIP)
  • Update Documentation for Front End
    • Developer
      • Frontend Tips/Organization
      • Front End Unit Tests
    • Sharing
    • Remove Frontend/JS Plugin Documentation ( should we just update this when we add the new addArticleAction Plugin API?)
  • use ?selected=<id> url query parameter to store and parse which Feed Item is displayed in FeedItemDisplay (this will be useful for implementing the search bar - and allow navigating directly to the specific feed item)
    • Also need to update search provider php code
    • Update Documentation?
  • addArticleAction Plugin API
    • Nextcloud News Code
    • Add to Bookmarks Example Plugin
    • Add New Frontend/JS Plugin Documentation

@devlinjunker devlinjunker added the Skip-Changelog No changelog update is required, minor change label Oct 4, 2023
@devlinjunker devlinjunker marked this pull request as ready for review October 5, 2023 17:36
@Grotax Grotax merged commit 60f319f into nextcloud:vue-rewrite Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants