Improve mobile view by using horizontal-split mobile layout
#3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devlin Junker <[email protected]>
|
It looks good so far, there are a few incorrect formatting |
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
devlinjunker
force-pushed
the
improve-mobile
branch
from
c1223f7 to
18bd3fb
Compare
wofferl
reviewed
Jan 11, 2025
Signed-off-by: Devlin Junker <[email protected]>
wofferl
approved these changes
Jan 26, 2025
4 tasks
Grotax
added a commit
that referenced
this pull request
Jan 30, 2025
Changed - Set mobileLayout to `horizontal-split` and add nav buttons for articles in mobile view (#3046) - set the duration after which a feed is considered sleepy to 7 days when using `nextUpdateTime` (#3074) - limit the time to the next update to a maximum of 24 hours when using `nextUpdateTime` (#3074) Fixed - Show error on folders only if at least one feed has more than eight errors (#3073) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Jan 30, 2025
Changed - Set mobileLayout to `horizontal-split` and add nav buttons for articles in mobile view (#3046) - set the duration after which a feed is considered sleepy to 7 days when using `nextUpdateTime` (#3074) - limit the time to the next update to a maximum of 24 hours when using `nextUpdateTime` (#3074) Fixed - Show error on folders only if at least one feed has more than eight errors (#3073) Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses new
mobileLayoutprop ofNcAppContentfrom nextcloud-libraries/nextcloud-vue#6364 and sets tohorizontal-splitAdds Navigation Arrows to top of
FeedItemDisplayto go to next/previous item when in mobile viewDepends on nextcloud-libraries/nextcloud-vue#6364
Checklist