replace net_url2 with guzzle #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SMillerDev what do you think? I checked the Net_URL2 repo and it seems a bit slow maintained open PRs, Issue Tracker also not really up to date. While I totally understand, I mean it's probably just a hobby, I thought maybe we can switch... |
|
Yeah, pear and pecl are deprecated so a replacement is good. Nice find on the PSR7. |
Hehe I just asked Gemini if there were any alternatives when I saw guzzle I though, hey we use that anyway and that project is still actively maintained 👍 I added two more tests to make sure it still does what it supposed to do, also learned that the Uri object is immutable so you have to store modifications in a new variable... |
SMillerDev
approved these changes
Mar 4, 2025
Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Mar 5, 2025
Fixed - preg_replace_callback(): Compilation failed: digits missing after \x or... (#3105) Signed-off-by: Benjamin Brahmer <[email protected]>
Merged
Grotax
added a commit
that referenced
this pull request
Mar 5, 2025
Fixed - preg_replace_callback(): Compilation failed: digits missing after \x or... (#3105) Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Mar 6, 2025
Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Mar 6, 2025
Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Mar 6, 2025
Signed-off-by: Benjamin Brahmer <[email protected]>
Grotax
added a commit
that referenced
this pull request
Mar 6, 2025
Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let's see if it works with guzzle.
Checklist