Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export v1: Add deprecation warning, remove --metadata-id-columns #1265

Merged
merged 3 commits into from
Jul 28, 2023
Merged

export v1: Add deprecation warning, remove --metadata-id-columns #1265

merged 3 commits into from
Jul 28, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jul 26, 2023 •
edited
Loading

Description of proposed changes

Start the process of removing export v1.

Related issue(s)

#1266

Testing

  • Test updated with deprecation warning
  • Checks pass

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.

@victorlin victorlin requested a review from a team July 26, 2023 21:24
@victorlin victorlin self-assigned this Jul 26, 2023
@victorlin victorlin mentioned this pull request Jul 26, 2023
Open
3 tasks
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (da6a9f2) 69.35% compared to head (0354812) 69.35%.

❗ Current head 0354812 differs from pull request most recent head 9384b32. Consider uploading reports for the commit 9384b32 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1265   +/-   ##
=======================================
  Coverage   69.35%   69.35%           
=======================================
  Files          66       66           
  Lines        7023     7023           
  Branches     1708     1708           
=======================================
  Hits         4871     4871           
  Misses       1847     1847           
  Partials      305      305
Files Changed Coverage Δ
augur/export_v1.py 74.27% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorlin victorlin force-pushed the victorlin/deprecate-export-v1 branch from d522be7 to 0354812 Compare July 26, 2023 22:10
@victorlin victorlin changed the title Deprecate export v1 Add deprecation warning to export v1 Jul 26, 2023
@victorlin victorlin mentioned this pull request Jul 26, 2023
Merged
1 task
@victorlin victorlin force-pushed the victorlin/deprecate-export-v1 branch from 0354812 to 2b4f015 Compare July 27, 2023 23:48
victorlin added 2 commits July 27, 2023 17:03
@victorlin
Add deprecation warning for export v1
faa9e79
@victorlin
export v1: Remove --metadata-id-columns
fa759ee 
This was added to both export v1 and v2 as part of a larger change¹, but
that change was incomplete and did not work as intended. It has been
fixed for export v2².

Since export v1 is no longer being maintained, remove the option instead
of trying to fix it here as well.

¹ 42f6cb2
² 9bf1b4c
@victorlin victorlin force-pushed the victorlin/deprecate-export-v1 branch from 2b4f015 to 1dddaf4 Compare July 28, 2023 00:03
@victorlin
Copy link
Member Author

In the force-pushes above, I tweaked the message a bit and added changelog entries. Will merge once tests pass.

@victorlin victorlin changed the title Add deprecation warning to export v1 export v1: Add deprecation warning, remove --metadata-id-columns Jul 28, 2023
@victorlin victorlin force-pushed the victorlin/deprecate-export-v1 branch from 1dddaf4 to 9384b32 Compare July 28, 2023 00:12
@victorlin victorlin merged commit f3dfd0e into master Jul 28, 2023
@victorlin victorlin deleted the victorlin/deprecate-export-v1 branch July 28, 2023 00:40
@victorlin victorlin mentioned this pull request Sep 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshadfield jameshadfield jameshadfield approved these changes

Assignees

@victorlin victorlin

Labels
None yet
Projects
No open projects
Nextstrain planning (archived)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorlin @jameshadfield