merge: Ignore the user's ~/.sqliterc file, if any #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genehack
approved these changes
Aug 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1608 +/- ##
=======================================
Coverage 71.02% 71.02%
=======================================
Files 79 79
Lines 8256 8256
Branches 2003 2003
=======================================
Hits 5864 5864
Misses 2101 2101
Partials 291 291 ☔ View full report in Codecov by Sentry. |
tsibley
force-pushed
the
trs/merge/no-sqliterc
branch
from
6397122 to
39c96d0
Compare
By default that file is evaluated by the SQLite CLI when it starts, and the user may have commands in it that affect default CLI behaviour we rely upon, such as .mode. Since it's hard to know exactly how to reset to a "pristine" settings state, avoid the user's rc file entirely. Resolves: <#1603>
tsibley
force-pushed
the
trs/merge/no-sqliterc
branch
from
39c96d0 to
d2589af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default that file is evaluated by the SQLite CLI when it starts, and the user may have commands in it that affect default CLI behaviour we rely upon, such as .mode. Since it's hard to know exactly how to reset to a "pristine" settings state, avoid the user's rc file entirely.
Resolves: #1603
Checklist