Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove augur.utils.read strains #1749

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Feb 10, 2025

Description of proposed changes

augur.utils.read_strains has been deprecated since January 2024.
Remove it so we stop duplicating augur.io.read_strains.

Related issue(s)

Resolves #1747

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@joverlee521 joverlee521 force-pushed the remove-utils-read-strains branch from b11dbae to d3146be Compare February 10, 2025 21:06
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (efaa592) to head (06a00f7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1749   +/-   ##
=======================================
  Coverage   73.23%   73.24%           
=======================================
  Files          79       79           
  Lines        8389     8384    -5     
  Branches     1709     1709           
=======================================
- Hits         6144     6141    -3     
+ Misses       1957     1955    -2     
  Partials      288      288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joverlee521 joverlee521 force-pushed the remove-utils-read-strains branch from 3e88bd9 to 7925efc Compare February 11, 2025 21:46
@joverlee521
Copy link
Contributor Author

Rebased to fix merge conflicts in changelog.

`augur.utils.read_strains` has been deprecated since January 2024.
Remove it so we stop duplicating `augur.io.read_strains`.
@joverlee521 joverlee521 force-pushed the remove-utils-read-strains branch from 7925efc to 06a00f7 Compare February 25, 2025 19:33
@joverlee521
Copy link
Contributor Author

Rebased to fix merge conflicts in changelog, will merge once all tests pass.

@joverlee521 joverlee521 merged commit c9db16d into master Feb 25, 2025
36 checks passed
@joverlee521 joverlee521 deleted the remove-utils-read-strains branch February 25, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove augur.utils.read_strains
2 participants