Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve titer model error messages #1769

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Feb 27, 2025

Description of proposed changes

Replaces the generic "not enough data" error message with the more detailed messages associated with the InsufficientDataException when it is raised.

Related issue(s)

Related to nextstrain/seasonal-flu#215

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

Replaces the generic "not enough data" error message with the more
detailed messages associated with the `InsufficientDataException` when
it is raised.
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (8cf91ae) to head (c21c5a8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
augur/titers.py 0.00% 4 Missing ⚠️
augur/titer_model.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1769   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          79       79           
  Lines        8391     8391           
  Branches     1712     1712           
=======================================
  Hits         6144     6144           
  Misses       1959     1959           
  Partials      288      288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huddlej huddlej merged commit 033c73b into master Mar 4, 2025
36 checks passed
@huddlej huddlej deleted the improve-titer-model-error-messages branch March 4, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants