Partial Unit Tests for Translate.py #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 18.68% 19.32% +0.63%
==========================================
Files 31 31
Lines 5053 5072 +19
Branches 1281 1288 +7
==========================================
+ Hits 944 980 +36
+ Misses 4082 4069 -13
+ Partials 27 23 -4
Continue to review full report at Codecov.
|
|
Thank you for the tests, @CodeSammich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This pull request includes initial tests for translate.py.
Related issue(s)
Related to #476
Testing
What steps should be taken to test the changes you've proposed?
Please run the runner.sh file and run tests as normal. Please note these are not exhaustive tests, as I had difficulty how to mock the TreeTime dict inputs for some of the other translate.py functions.
Thank you for contributing to Nextstrain!