Filter: Add '--query' for complex queries #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rneher
approved these changes
May 25, 2020
|
I think this looks great. |
|
This is slick! Thanks again, @danielsoneg. |
|
Thanks so much for your patience and your hard work @danielsoneg !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add a
--queryflag toaugur filterto allow complex querying using Pandas' DataFrame.query method. This is a rehash of #455, cleaned up and updated per comments on that thread.Related issue(s)
Fixes #244
Related to #455
This is a cleanup and re-submit of #455 following conversations there.
Testing
Ran through the test suite and added unit tests to check this behavior.
Thank you for contributing to Nextstrain!
You're welcome! 😊