Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/skyline export #556

Merged
merged 2 commits into from
May 25, 2020
Merged

Fix/skyline export #556

merged 2 commits into from
May 25, 2020

Conversation

rneher
Copy link
Member

@rneher rneher commented May 25, 2020

Description of proposed changes

this catches a failed skyline optimization by treetime and fails refine.

Related issue(s)

Related to #554

Testing

This seems to have happened in some edge cases and has its root in failure of convergence of the skyline optimziation

Thank you for contributing to Nextstrain!

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #556 into master will decrease coverage by 0.13%.
The diff coverage is 8.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   19.47%   19.33%   -0.14%     
==========================================
  Files          31       31              
  Lines        5073     5120      +47     
  Branches     1284     1301      +17     
==========================================
+ Hits          988      990       +2     
- Misses       4062     4106      +44     
- Partials       23       24       +1     
Impacted Files Coverage Δ
augur/refine.py 5.32% <0.00%> (-0.13%) ⬇️
augur/traits.py 7.82% <0.00%> (ø)
augur/utils.py 27.63% <0.00%> (ø)
augur/validate.py 25.80% <0.00%> (ø)
augur/parse.py 10.60% <3.22%> (ø)
augur/align.py 38.46% <14.28%> (-8.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0642487...ceca09e. Read the comment docs.

@rneher rneher merged commit e30703f into master May 25, 2020
@rneher rneher deleted the fix/skyline-export branch May 25, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant