Exit when a tree cannot be read by the node data reader #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning None when the tree cannot be read by the node data reader, exit like the other methods in the class do. This commit adds a unit test to represent this expected behavior.
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
+ Coverage 28.31% 28.38% +0.06%
==========================================
Files 39 39
Lines 5332 5331 -1
Branches 1306 1306
==========================================
+ Hits 1510 1513 +3
+ Misses 3769 3765 -4
Partials 53 53
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning None when the tree cannot be read by the node data reader,
exit like the other methods in the class do. This commit adds a unit test to
represent this expected behavior.