Allow extensions block in auspice config & dataset JSONs, add --skip-validation
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows auspice config JSONs to define an "extensions" block which is passed through unchanged to the dataset JSON. This is intended for use by other applications (i.e. not auspice) and, as such, no schema for the block is specified. Tests added & can be run via `cram --shell=/bin/bash tests/functional/export_v2.t` Closes #861
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
- Coverage 34.31% 34.28% -0.03%
==========================================
Files 41 41
Lines 5937 5942 +5
Branches 1518 1521 +3
==========================================
Hits 2037 2037
- Misses 3818 3823 +5
Partials 82 82
Continue to review full report at Codecov.
|
corneliusroemer
approved these changes
Mar 11, 2022
huddlej
reviewed
Mar 11, 2022
There was a problem hiding this comment.
This looks good, @jameshadfield. Do you want functional tests for an invalid JSON with and with the new --skip-validation flag to confirm that this functionality works as expected?
jameshadfield
force-pushed
the
feat/export-extensions
branch
from
7774e6e to
c014fe6
Compare
An appropriate warning is added to the argument, but this can be useful in certain situations and can result in a large speed-up (it speeds up generation of a large testing dataset from 2m27s to 8s). As discussed in #861
jameshadfield
force-pushed
the
feat/export-extensions
branch
from
c014fe6 to
29a9357
Compare
Good idea! Added via b0c383b. Will merge once CI passes. |
This was referenced Apr 6, 2022
corneliusroemer
changed the title
--skip-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for further info