filter: Handle errors from filter_by_query
#942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
========================================
Coverage 59.34% 59.34%
========================================
Files 42 50 +8
Lines 6011 6257 +246
Branches 1539 1584 +45
========================================
+ Hits 3567 3713 +146
- Misses 2185 2283 +98
- Partials 259 261 +2
Continue to review full report at Codecov.
|
victorlin
force-pushed
the
filter/handle-query-errors
branch
2 times, most recently
from
f339f40 to
62c21fc
Compare
tsibley
requested changes
Jun 14, 2022
- The underlying pandas engine used for --query can raise various errors depending on the input. - The query call is invoked by a loop through all filtering functions. Based on the above points, this change wraps the line executing filter functions and catches all errors, but only handles the errors from filter_by_query. For the errors from filter_by_query, the UndefinedVariableError is predictable enough to mean that a column does not exist. For all other errors, raise a generic error message directing users to the pandas query syntax doc page.
victorlin
force-pushed
the
filter/handle-query-errors
branch
from
62c21fc to
d1a063a
Compare
|
@tsibley thanks for the pointers! Will merge when checks pass. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
--querycan raise various errors depending on the input.Based on the above points, this change wraps the line executing filter functions and catches all errors, but only handles the errors from filter_by_query.
For the errors from filter_by_query, the
UndefinedVariableErroris predictable enough to mean that a column does not exist. For all other errors, raise a generic error message directing users to the pandas query syntax doc page.Related issue(s)
UndefinedVariableError/KeyErrorwhen using--querywith a non-existent column #939ValueErrorwhen using--querywith=#940SyntaxErrorwhen using--querywith bad syntax #941Testing
Added functional tests.