-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter: Fix duplicates from force inclusions #986
filter: Fix duplicates from force inclusions #986
Conversation
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
- Coverage 59.22% 59.20% -0.03%
==========================================
Files 50 50
Lines 6259 6260 +1
Branches 1586 1586
==========================================
- Hits 3707 3706 -1
- Misses 2290 2292 +2
Partials 262 262
Continue to review full report at Codecov.
|
tests/functional/filter/cram/filter-force-include-no-duplicates.t
Outdated
Show resolved
Hide resolved
6393aeb
to
2187f78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't completely grasped what happens in augur filter
but the test outputs and overall change makes sense to me. I only left a non-blocking question and comment.
f6836dc
to
d97611f
Compare
- strains_to_write -> force_included_strains_to_write - distinct_sequences_to_include -> distinct_force_included_strains
This fixes double-writing of the same record.
d97611f
to
5def1a7
Compare
Description of proposed changes
This fixes double-writing of the same record in output files.
Related issue(s)
--include
/--include-where
leads to duplicate entries in outputs #985Testing
Tests added. See checks before and after fix.