Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: Move register_arguments to top of file #995

Merged

Conversation

victorlin
Copy link
Member

Description of proposed changes

Having register_arguments at the top of the file makes more sense to me
since it describes the high-level functionality of this module.

Related issue(s)

N/A

Testing

N/A

Having register_arguments at the top of the file makes more sense to me
since it describes the high-level functionality of this module.
@victorlin victorlin requested a review from a team June 30, 2022 23:13
@victorlin victorlin self-assigned this Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #995 (7dfd547) into master (a1d418d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #995   +/-   ##
=======================================
  Coverage   59.24%   59.24%           
=======================================
  Files          50       50           
  Lines        6266     6266           
  Branches     1588     1588           
=======================================
  Hits         3712     3712           
  Misses       2292     2292           
  Partials      262      262           
Impacted Files Coverage Δ
augur/__version__.py 100.00% <100.00%> (ø)
augur/filter.py 95.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd2d4c...7dfd547. Read the comment docs.

@victorlin victorlin merged commit 0d06558 into nextstrain:master Jun 30, 2022
@victorlin victorlin deleted the filter/move-register-arguments branch June 30, 2022 23:24
@huddlej huddlej added this to the Patch release 16.0.3 milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants