Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move animation controls to the sidebar #1262

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Jan 11, 2021

Description of proposed changes

The play / pause / reset buttons were originally placed in the upper left corner of the map to highlight this functionality for Zika and Ebola where animation works well. With emphasis on SARS-CoV-2, we should no longer highlight animation. It doesn't work well for the large SARS-CoV-2 trees.

Placing play / pause / reset under the date slider also helps to show what's actually going on with the animation.

The play / pause / reset buttons were originally placed in the upper left corner of the map to highlight this functionality for Zika and Ebola where animation works well. With emphasis on SARS-CoV-2, we should no longer highlight animation. It doesn't work well for the large SARS-CoV-2 trees.

Placing play / pause / reset under the date slider also helps to show what's actually going on with the animation.
@trvrb trvrb requested a review from jameshadfield January 11, 2021 01:52
@jameshadfield jameshadfield temporarily deployed to auspice-animation-contr-hwnyf5 January 11, 2021 01:53 Inactive
This trades off less-than ideal appearence in (default) auspice
for a more appealing nextstrain.org version. In future, the
sidebar theme customisation should be able to define this.
@jameshadfield jameshadfield temporarily deployed to auspice-animation-contr-hwnyf5 January 11, 2021 04:54 Inactive
@jameshadfield jameshadfield merged commit cd30947 into master Jan 11, 2021
@jameshadfield jameshadfield deleted the animation-controls branch January 11, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants