-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow negative dates, y labels, better spacing #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshadfield
approved these changes
Aug 4, 2018
great. I think the horizontal grid lines are useful. |
I really like the horizontal grid lines for clock display. This labeling makes clock display much less opaque. |
Ahhh merged without seeing that message! I'll fix the bug now. Update: see #612 |
jameshadfield
added a commit
that referenced
this pull request
Aug 4, 2018
By storing references to <g> elements, we don't have to create new ones upon updates. This also preserves the initial ordering of groups, avoiding bugs such as #610 (comment)
Merged
jameshadfield
added a commit
that referenced
this pull request
Aug 4, 2018
By storing references to <g> elements, we don't have to create new ones upon updates. This also preserves the initial ordering of groups, avoiding bugs such as #610 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the long-standing issue #483 and other non-documented problems with the tree grid. It now allows